errose28 commented on PR #3920: URL: https://github.com/apache/ozone/pull/3920#issuecomment-1360842819
> Another related point is whether RatisContainerReplicaCount should see all replicas that don't match with the container's state or only replicas that have UNHEALTHY state as "unhealthy". This affects the behaviour of isSufficientlyReplicated in that class. Right. Currently I am not counting the unhealthy replicas towards sufficient replication. This was done to minimize the changes to RatisContainerReplicaCount since this class is shared by the old and new RM. It seems this is causing test failures in the recently merged TestRatisOverReplicationHandler though. Ultimately I think what needs to happen is RatisContainerReplicaCount gets refactored to more explicitly deal with unhealthy replicas. However I don't think we should do this while two RM implementations are using the same class for different unhealthy replica handling. I think we should leave RatisContainerReplicaCount as is in this PR and ignore the failures in TestRatisOverReplicationHandler. When unhealthy replica handling is ported to the new RM and we are ready to turn off the old RM, we can refactor RatisContainerReplicaCount. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
