devmadhuu commented on code in PR #4107: URL: https://github.com/apache/ozone/pull/4107#discussion_r1052946425
########## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/tasks/ContainerSizeCountTask.java: ########## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.ozone.recon.tasks; + + +import org.apache.hadoop.hdds.scm.container.ContainerInfo; +import org.apache.hadoop.hdds.scm.container.ContainerManager; +import org.apache.hadoop.ozone.recon.ReconUtils; +import org.apache.hadoop.ozone.recon.scm.ReconScmTask; +import org.apache.hadoop.ozone.recon.spi.StorageContainerServiceProvider; +import org.hadoop.ozone.recon.schema.tables.daos.ContainerCountBySizeDao; +import org.hadoop.ozone.recon.schema.tables.daos.ReconTaskStatusDao; +import org.hadoop.ozone.recon.schema.tables.pojos.ContainerCountBySize; +import org.jooq.DSLContext; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.util.ArrayList; +import java.util.HashMap; +import java.util.List; +import java.util.Map; + +import static org.hadoop.ozone.recon.schema.tables.ContainerCountBySizeTable.CONTAINER_COUNT_BY_SIZE; + + +/** + * Class that scans the list of containers and keeps track of container sizes + * binned into ranges (1KB, 2Kb..,4MB,.., 1TB,..1PB) to the Recon + * containerSize DB. + */ +public class ContainerSizeCountTask extends ReconScmTask { + + private static final Logger LOG = + LoggerFactory.getLogger(ContainerSizeCountTask.class); + + private StorageContainerServiceProvider scmClient; + private ContainerManager containerManager; + private final long interval; + private ContainerCountBySizeDao containerCountBySizeDao; + private DSLContext dslContext; + + + public ContainerSizeCountTask( + ContainerManager containerManager, + StorageContainerServiceProvider scmClient, + ReconTaskStatusDao reconTaskStatusDao, + ReconTaskConfig reconTaskConfig, + ContainerCountBySizeDao containerCountBySizeDao, + DSLContext dslContext) { + super(reconTaskStatusDao); + this.scmClient = scmClient; + this.containerManager = containerManager; + this.containerCountBySizeDao = containerCountBySizeDao; + this.dslContext = dslContext; + interval = reconTaskConfig.getContainerSizeCountTaskInterval().toMillis(); + } + + + @Override + protected synchronized void run() { + try { + while (canRun()) { + wait(interval); + + final List<ContainerInfo> containers = containerManager.getContainers(); + Map<ContainerSizeCountKey, Long> containerSizeCountMap = + new HashMap<>(); + for (int i = 0; i < containers.size(); i++) { + handlePutKeyEvent(containers.get(i), containerSizeCountMap); Review Comment: Try to do profile and time test this with at least 100K containers, as we are deleting whole table below and doing fresh operation every 5 mins. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
