smengcl commented on code in PR #4011:
URL: https://github.com/apache/ozone/pull/4011#discussion_r1053666763


##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconDeadNodeHandler.java:
##########
@@ -71,6 +77,8 @@ public void onMessage(final DatanodeDetails datanodeDetails,
         LOG.warn("Node {} has reached DEAD state, but SCM does not have " +
             "information about it.", datanodeDetails);
       }
+      containerHealthTask.triggerContainerHealthCheck();
+      pipelineSyncTask.triggerPipelineSyncTask();

Review Comment:
   Q: Would a single `triggerContainerHealthCheck` or `triggerPipelineSyncTask` 
run be time consuming or resource intensive? Since this imply every time 
`onMessage` here is entered, those two tasks would be triggered.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to