devmadhuu commented on code in PR #4011:
URL: https://github.com/apache/ozone/pull/4011#discussion_r1053994085
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/scm/ReconDeadNodeHandler.java:
##########
@@ -71,6 +77,8 @@ public void onMessage(final DatanodeDetails datanodeDetails,
LOG.warn("Node {} has reached DEAD state, but SCM does not have " +
"information about it.", datanodeDetails);
}
+ containerHealthTask.triggerContainerHealthCheck();
+ pipelineSyncTask.triggerPipelineSyncTask();
Review Comment:
@smengcl - thanks for review. I understood your question, so here is
explanation:
Both the existing tasks "`ContainerHealthTask`" and "`PipelineSyncTask`" are
currently being run at interval of 5 mins and they are not resource intensive,
so after refactoring the code and moved the logic to
"`triggerContainerHealthCheck`" its being called on DeadNode event which is
configured default as 10 mins and for "`triggerPipelineSyncTask`", this is
being called on both DeadNode (Configured default interval is 10 mins) and
StaleNode event (Configured default interval is 5 mins), so there will not be
any issue as existing also these tasks were run each at interval of 5 mins.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
