jojochuang commented on code in PR #4089:
URL: https://github.com/apache/ozone/pull/4089#discussion_r1053850440
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java:
##########
@@ -292,15 +272,17 @@ private static ArchiveOutputStream tar(OutputStream
output) {
return new TarArchiveOutputStream(output);
}
- private InputStream decompress(InputStream input)
+ public InputStream decompress(InputStream input)
Review Comment:
If the scope is only opened up for tests, I think you don't need to make it
public.
Make it package-private is good enough, and use VisibleForTesting annotation
to flag that the scope is only opened up for tests.
```suggestion
@VisibleForTesting
InputStream decompress(InputStream input)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
