jojochuang commented on code in PR #4089:
URL: https://github.com/apache/ozone/pull/4089#discussion_r1055779646
##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/replication/OnDemandContainerReplicationSource.java:
##########
@@ -61,7 +69,8 @@ public void copyData(long containerId, OutputStream
destination)
}
controller.exportContainer(
- container.getContainerType(), containerId, destination, packer);
+ container.getContainerType(), containerId, destination,
+ packer.get(compression));
Review Comment:
Ok. Here we need to take care of exceptions: Can you add a check to ensure
compression string is expected and throw exception when it's not?
+1 after this final change.
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/debug/container/ExportSubcommand.java:
##########
@@ -74,7 +76,7 @@ public Void call() throws Exception {
new File(destination, "container-" + containerId + ".tar.gz");
try (FileOutputStream fos = new FileOutputStream(destinationFile)) {
try {
- replicationSource.copyData(containerId, fos);
+ replicationSource.copyData(containerId, fos, GZIP);
Review Comment:
I think we should revisit this one later.
Potentially add a command parameter to specify compression. For now, gzip is
good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
