xBis7 commented on PR #4116: URL: https://github.com/apache/ozone/pull/4116#issuecomment-1362638378
@neils-dev Thanks for looking into this PR. In `OzoneManagerProtocolServerSideTranslatorPB` during `processRequest` we assign the `S3Authentication` value to `static OzoneManager.setS3Auth` [here](https://github.com/apache/ozone/blob/2c973f79822624dc62747266fda4eb34b914f498/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java#L165), making it available to OM for all the necessary actions but right before exiting `processRequest` we reset it's value to null [here](https://github.com/apache/ozone/blob/2c973f79822624dc62747266fda4eb34b914f498/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java#L214). By the time we try to access it in `OzoneIdentityProvider` it's value is always null. On the other hand, the ThreadLocal field `S3_AUTH_THREAD_LOCAL` in `OzoneManagerProtocolServerSideTranslatorPB` is only used for `OzoneIdentityProvider` so we don't need to reset it's value explicitly. > Also, it looks like an integration test in the CI stopped the green workflow. Check to see if unrelated. It's unrelated. I have 3 green builds in a row in my fork's CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
