Xushaohong commented on PR #4128: URL: https://github.com/apache/ozone/pull/4128#issuecomment-1370694949
> * I don't see admin checks for the leader transfer commands, although I just quickly skimmed the change so please correct me if I missed them. Hi @errose28, could you explain what is the admin check? Or any examples I can follow. > * This might be easier to review if the SCM leader change portion is done in a separate PR. Most of the logic is similar for OM and SCM, so I have abstracted the common part logic into one function. Is it required to divide them apart into two PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
