errose28 commented on PR #4128: URL: https://github.com/apache/ozone/pull/4128#issuecomment-1371312822
It's not required to divide them, but it might speed up reviewing if OM changes + common changes are in one PR, and then SCM changes follow in another PR. The PR is currently not that large though so either way is fine. For admin checks, look at callers of `OzoneManager#isAdmin` in OM and `StorageContainerManager#checkAdminAccess` in SCM for examples. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
