sumitagrawl commented on code in PR #4029: URL: https://github.com/apache/ozone/pull/4029#discussion_r1068921501
########## hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RWBatchOperation.java: ########## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + * + */ +package org.apache.hadoop.hdds.utils.db; + +import java.io.IOException; +import org.apache.hadoop.hdds.utils.db.managed.ManagedRocksIterator; +import org.rocksdb.ColumnFamilyHandle; + +/** + * Class represents a read write batch operation, + * collects multiple db operation. + */ +public interface RWBatchOperation extends BatchOperation { + ManagedRocksIterator newIteratorWithBase( + ColumnFamilyHandle handle, ManagedRocksIterator newIterator) + throws IOException; + + void lockOperation() throws IOException; + + void releaseOperation(); Review Comment: @errose28 When DBIterator is iterating buffer, and parallel flush happens in takeSnapshot, this causes failure of current iterator. Do avoid this failure, a lock is added. Chances of flush is less as its done on takeSnapshot after huge count of operation (like 50000). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
