sumitagrawl commented on code in PR #4029:
URL: https://github.com/apache/ozone/pull/4029#discussion_r1068932374
##########
hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/utils/db/RocksDatabase.java:
##########
@@ -300,6 +301,32 @@ public void batchPut(ManagedWriteBatch writeBatch, byte[]
key, byte[] value)
counter.decrementAndGet();
}
}
+
+ public void batchDelete(ManagedReadWriteBatch writeBatch, byte[] key)
+ throws IOException {
Review Comment:
@errose28 I tried to use base class, but since RocksDB defined separate
method and can not have any strategy. Another way is using typecast in common
method, but this will add if else complexity, So IMO having separate method is
better in this case.
Its usages limitation of RocksDB.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
