errose28 commented on code in PR #4186:
URL: https://github.com/apache/ozone/pull/4186#discussion_r1085637446
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectPut.java:
##########
@@ -288,4 +297,80 @@ public void testEmptyStorageType() throws IOException,
OS3Exception {
//default type is set
Assert.assertEquals(ReplicationType.RATIS, key.getReplicationType());
}
+
+ @Test
+ public void testDirectoryCreation() throws IOException,
Review Comment:
I think the tests can still be done in in this class. I was just wondering
if we could use the existing `clientStub` and `objectEndpoint` instances in
this test like the other tests in the class do. If it's too complicated or not
as good, for example because the client stub classes do not save directory or
FSO information like we need here, the extra mocking could make sense, I was
just wondering if there was a reason for doing it this way.
If we do keep it this way we should verify invocation count on the mocked
`OzoneBucket#createDirectory` in each test in addition to the return code that
is already being checked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
