mladjan-gadzic commented on code in PR #4186:
URL: https://github.com/apache/ozone/pull/4186#discussion_r1097257800
##########
hadoop-ozone/s3gateway/src/test/java/org/apache/hadoop/ozone/s3/endpoint/TestObjectPut.java:
##########
@@ -288,4 +298,82 @@ public void testEmptyStorageType() throws IOException,
OS3Exception {
//default type is set
Assert.assertEquals(ReplicationType.RATIS, key.getReplicationType());
}
+
+ @Test
+ public void testDirectoryCreation() throws IOException,
+ OS3Exception {
+ // GIVEN
+ final String bucketname = "bucketName";
Review Comment:
That is a possibility. I just want to keep unit tests isolated as much as
possible for a piece of mind. Will refactor to that.
EDIT: I missread, thought you were suggesting to use `bucketName` instead. I
will check if checkstyle is okay with that. If not I will just use class level
variable `bucketName` instead because it will not make any negative impact in
the end.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
