duongkame opened a new pull request, #4212: URL: https://github.com/apache/ozone/pull/4212
## What changes were proposed in this pull request? This is a correction of the fix for "SCM terminates when adding containers to a closed pipeline" in [HDDS-7738](https://issues.apache.org/jira/browse/HDDS-7738). In general, due to the lack of atomicity and the fact that SCM status can change between transactions, SCM should just reject transactions gracefully if some logical condition is not met. For example, when processing a transaction adding a container, SCM expects the associated pipeline to be in an `OPEN` state and rejects the container creation if the pipeline is `CLOSED`. ## What is the link to the Apache JIRA https://issues.apache.org/jira/browse/HDDS-7829 ## How was this patch tested? Unit test. I could not find a definite way to create an integration test for this situation, because it involves some race-condition, i.e. pipeline is closed right after being allocated to a container. Yet, I manually injected errors and verified that SCM works normally after rejecting the failed transaction. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
