errose28 commented on code in PR #4212:
URL: https://github.com/apache/ozone/pull/4212#discussion_r1092614358
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMStateMachine.java:
##########
@@ -136,7 +137,14 @@ public CompletableFuture<Message> applyTransaction(
try {
final SCMRatisRequest request = SCMRatisRequest.decode(
Message.valueOf(trx.getStateMachineLogEntry().getLogData()));
- applyTransactionFuture.complete(process(request));
+
+ try {
+ applyTransactionFuture.complete(process(request));
+ } catch (SCMException ex) {
+ // SCMException is considered as logical rejection and is returned to
+ // Ratis client.
Review Comment:
From `SCMException#ResultCodes`, `IO_EXCEPTION` and `INTERNAL_ERROR` should
probably still crash the SCM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
