ivanandika98 commented on PR #4224:
URL: https://github.com/apache/ozone/pull/4224#issuecomment-1411487661

   @symious thanks for the input. I would say `OMLayoutFeature.values()` and 
`HDDSLayoutFeature.values()` will generate an ordinal-indexed array (from the 
lowest to highest ordinal), so it is indirectly accessing the ordinals of the 
enums.
   Although it is odd that the `OMLayoutFeature` `LayoutVersion` test only 
assert that the `LayoutVersion` is increasing, while `HDDSLayoutFeature` 
`LayoutVersion` test additionally asserts that the first version must be 0 and 
only can be incremented by 1. Should we standardize these two tests?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to