errose28 commented on PR #4224: URL: https://github.com/apache/ozone/pull/4224#issuecomment-1412728951
> Although it is odd that the OMLayoutFeature LayoutVersion test only assert that the LayoutVersion is increasing, while HDDSLayoutFeature LayoutVersion test additionally asserts that the first version must be 0 and only can be incremented by 1. Should we standardize these two tests? Yeah let's make testOMLayoutFeaturesHaveIncreasingLayoutVersion test that the layout version is increasing by one for each enum entry. It looks like #2160 took care of most of what is described in this jira and the task was never updated, so with this minor change we can probably complete this task. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
