smengcl commented on code in PR #4230:
URL: https://github.com/apache/ozone/pull/4230#discussion_r1093664505
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneSnapshotRestore.java:
##########
@@ -258,9 +259,24 @@ public void
testRestoreSnapshotDifferentBucket(BucketLayout bucketLayoutTest)
int volBucketKeyCount = keyCount(buck, snapshotKeyPrefix + keyPrefix);
Assertions.assertEquals(5, volBucketKeyCount);
+ // Delete keys from the source bucket.
Review Comment:
> Problem is that RocksDB's seek operation doesn't 100% guarantee that item
key is available. Tho we believe that it is. When we seek if there is a
directory for the key name, sometime it returns non-null response but in
reality item doesn't exist.
This could be a bug. When locating a key (e.g. checking existence), OM is
responsible for verifying that the key name exactly matches the input right
after an iterator seek. But I have yet to fully understand the intention of
`createFakeDirIfShould` to make a call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
