hemantk-12 commented on code in PR #4230:
URL: https://github.com/apache/ozone/pull/4230#discussion_r1093668802
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneSnapshotRestore.java:
##########
@@ -258,9 +259,24 @@ public void
testRestoreSnapshotDifferentBucket(BucketLayout bucketLayoutTest)
int volBucketKeyCount = keyCount(buck, snapshotKeyPrefix + keyPrefix);
Assertions.assertEquals(5, volBucketKeyCount);
+ // Delete keys from the source bucket.
Review Comment:
I agree with @smengcl on checkout intention of `createFakeDirIfShould` and
that's why I went ahead by deleting the keys from source bucket because it
doesn't matter for that test if keys are present in source bucket. The
requirement for test is that keys should be present in snapshot path
(snapshotKeyPrefix).
##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/snapshot/TestOzoneSnapshotRestore.java:
##########
@@ -258,9 +259,24 @@ public void
testRestoreSnapshotDifferentBucket(BucketLayout bucketLayoutTest)
int volBucketKeyCount = keyCount(buck, snapshotKeyPrefix + keyPrefix);
Assertions.assertEquals(5, volBucketKeyCount);
+ // Delete keys from the source bucket.
Review Comment:
I agree with @smengcl on checking intention of `createFakeDirIfShould` and
that's why I went ahead by deleting the keys from source bucket because it
doesn't matter for that test if keys are present in source bucket. The
requirement for test is that keys should be present in snapshot path
(snapshotKeyPrefix).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
