hemantk-12 commented on PR #4125: URL: https://github.com/apache/ozone/pull/4125#issuecomment-1414272443
> @hemantk-12 Would [this approach](https://github.com/xBis7/ozone/blob/5509ccd365232933fc51c0a688a61a4e2d5d4699/hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotKeyHandler.java) seem cleaner? That's from commit [5509ccd](https://github.com/apache/ozone/commit/5509ccd365232933fc51c0a688a61a4e2d5d4699). TBH, I'm not sure if that it clearen either. To me, `ListKeyHandler` should be independent of `bucketPath` or `snapshotPath`. You can have different internal implementations of `ListKeyHandler` based on path type is bucket or snapshot if needed but high level it should be independent. As I said earlier, `SnapshotHandler` says that it is to handle snapshot reqeust like snapshot create, delete or list snapshot not listing the keys from snapshot. Again this is what I think based on my experience with Ozone so far. May be @smengcl or @prashantpogde can look and help us here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
