hemantk-12 commented on PR #4125: URL: https://github.com/apache/ozone/pull/4125#issuecomment-1414509405
> @hemantk-12 @smengcl Thanks for the reviews, I've updated the patch. I get your point about the `SnapshotHandler` class. > > > You can have different internal implementations of ListKeyHandler based on path type is bucket or snapshot if needed but high level it should be independent. > > This would be the best, but we would have to reorganize all Handler classes and that would require changes across all shell commands. If we are to go that way, it should be in another PR. > > > we could rename SnapshotHandler into something like BucketAndSnapshotHandler in order not to give the wrong impression? > > This seemed the easiest approach, so I renamed the class to `BucketSnapshotHandler`. Doing it as part of another PR is completely fine by me. Thanks for change the name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
