smengcl commented on code in PR #4134:
URL: https://github.com/apache/ozone/pull/4134#discussion_r1096126162


##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -784,6 +804,28 @@ private List<FileStatusAdapter> listStatusVolume(String 
volumeStr,
     return res;
   }
 
+  /**
+   * Helper for OFS listStatus on a bucket to get all snapshots.
+   */
+  private List<FileStatusAdapter> listStatusBucketSnapshot(
+      String volumeName, String bucketName, URI uri) throws IOException {
+    List<OzoneSnapshot> snapshotList =
+        objectStore.listSnapshot(volumeName, bucketName);

Review Comment:
   Does `listSnapshot` by default filter out all snapshot that are not 
`ACTIVE`? For example, snapshots that are deleted pending reclaimation would 
still remain in the OM table.
   
   If not we can add a filter in the stream below.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to