xBis7 commented on code in PR #4134:
URL: https://github.com/apache/ozone/pull/4134#discussion_r1096505256
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneClientAdapterImpl.java:
##########
@@ -784,6 +804,28 @@ private List<FileStatusAdapter> listStatusVolume(String
volumeStr,
return res;
}
+ /**
+ * Helper for OFS listStatus on a bucket to get all snapshots.
+ */
+ private List<FileStatusAdapter> listStatusBucketSnapshot(
+ String volumeName, String bucketName, URI uri) throws IOException {
+ List<OzoneSnapshot> snapshotList =
+ objectStore.listSnapshot(volumeName, bucketName);
Review Comment:
I didn't create `listSnapshot()`,
[here](https://github.com/xBis7/ozone/blob/HDDS-7513/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java#L1200-L1206)
is the implementation. There are other places or commands using this method.
If we add the filter below here, we wouldn't be that consistent but on the
other hand we might need `listSnapshot()` to return all the snapshots and not
just the `ACTIVE` ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
