kerneltime commented on code in PR #3691:
URL: https://github.com/apache/ozone/pull/3691#discussion_r1098101481
##########
hadoop-hdds/interface-client/src/main/proto/hdds.proto:
##########
@@ -451,3 +451,10 @@ message ContainerBalancerConfigurationProto {
required bool shouldRun = 18;
optional int32 nextIterationIndex = 19;
}
+
+message DeletedBlocksTransactionInfo {
+ required int64 txID = 1;
Review Comment:
In general, we should let the proto layer mark args as optional and deal
with it on the server side? I would mark most of these args as optional. cc
@errose28
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
