kerneltime commented on code in PR #3691:
URL: https://github.com/apache/ozone/pull/3691#discussion_r1098102621
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/DeletedBlockLogImpl.java:
##########
@@ -191,7 +200,7 @@ public int resetCount(List<Long> txIDs) throws IOException,
TimeoutException {
lock.lock();
try {
if (txIDs == null || txIDs.isEmpty()) {
- txIDs = getFailedTransactions().stream()
+ txIDs = getFailedTransactions(-1).stream()
Review Comment:
I would avoid magic numbers, you can define some constants for these which
make it obvious what is intended Example: `LIST_ALL_FAILED_TRANSACTIONS`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
