xichen01 commented on code in PR #4251:
URL: https://github.com/apache/ozone/pull/4251#discussion_r1101372262
##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java:
##########
@@ -92,6 +98,18 @@ public class BaseFreonGenerator {
defaultValue = "10")
private int threadNo;
+ @Option(names = {"--timebase"},
+ description = "If set, freon will run for the duration of the --runtime"
+ + " specified even if the --number-of-tests operation"
+ + " has been completed.",
+ defaultValue = "false")
+ private boolean timebase;
+
+ @Option(names = {"--runtime"},
+ description = "Tell freon to terminate processing after"
+ + "the specified period of time in seconds.")
+ private long runtime;
Review Comment:
@ adoroszlai The option of `--min-duration and --max-duration` or
`--timebase and --runtime` which do you think is better. If easy to understand
is more important, I think `--timebase and --runtime` is easier to understand
(But maybe I have some issues that I haven't considered).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
