xichen01 commented on code in PR #4251:
URL: https://github.com/apache/ozone/pull/4251#discussion_r1107505873


##########
hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/freon/BaseFreonGenerator.java:
##########
@@ -92,6 +98,18 @@ public class BaseFreonGenerator {
       defaultValue = "10")
   private int threadNo;
 
+  @Option(names = {"--timebase"},
+      description = "If set, freon will run for the duration of the --runtime"
+          + " specified even if the --number-of-tests operation"
+          + " has been completed.",
+      defaultValue = "false")
+  private boolean timebase;
+
+  @Option(names = {"--runtime"},
+      description = "Tell freon to terminate processing after"
+          + "the specified period of time in seconds.")
+  private long runtime;

Review Comment:
   Ok, I will change it to the suggested "--min-duration" and "--max-duration".
   But if both `-n N` and `--min/max-duration X` are given the real-time 
progress bar may be difficult to implement, because the final run time is 
uncertain. So in this case, instead of printing the real-time progress bar, the 
number of executions and the executions time will be printed
   such as:
   `operations executed times: 100, runtime: 30s`
   if the "--min-duration" and "--max-duration" are both not given, the 
progress bar will the same as before



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to