sodonnel commented on code in PR #4269:
URL: https://github.com/apache/ozone/pull/4269#discussion_r1104363279
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/ECKeyOutputStream.java:
##########
@@ -548,7 +553,7 @@ private void addStripeToQueue(ECChunkBuffers stripe) throws
IOException {
private boolean flushStripeFromQueue() throws IOException {
try {
ECChunkBuffers stripe = ecStripeQueue.take();
- while (!(stripe instanceof EOFDummyStripe)) {
+ while (!closing && !(stripe instanceof EOFDummyStripe)) {
Review Comment:
It guess it can only be closing=true at this point if there was a previous
write exception that got thrown back to the caller. At that point, the caller
needs to call close(). If they try to write again, they should see errors as
the stream is "closing".
However I do wonder if we should check for and flush queued stripes in the
close() method when closing = true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
