adoroszlai commented on code in PR #4269:
URL: https://github.com/apache/ozone/pull/4269#discussion_r1105473968
##########
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/KeyOutputStream.java:
##########
@@ -335,7 +335,7 @@ private void handleException(BlockOutputStreamEntry
streamEntry,
excludeList.addPipeline(pipelineId);
}
// just clean up the current stream.
- streamEntry.cleanup(!retryFailure);
+ streamEntry.cleanup(retryFailure);
Review Comment:
Yes, this part of the revert is intentional. `retryFailure` name has two
possible meanings: "retry the failure" or "retry has failed". I had assumed it
is the first one, but closer look at the code revelead it is the second one.
So the original code was OK, we should invalidate the client on `retryFailure`
(HDDS-959).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
