xBis7 commented on code in PR #4140:
URL: https://github.com/apache/ozone/pull/4140#discussion_r1112861655
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1826,6 +1828,20 @@ public void updatePeerList(List<String> newPeers) {
}
}
}
+ String leaderId = "";
+ if (isRatisEnabled) {
+ RaftPeer leader = null;
+ try {
+ leader = omRatisServer.getLeader();
+ } catch (IOException ex) {
+ LOG.error("IOException while getting the " +
+ "Ratis server leader.", ex);
+ }
+ if (Objects.nonNull(leader)) {
+ leaderId = leader.getId().toString();
+ }
+ }
+ omHAMetricsInit(leaderId);
Review Comment:
> Undefined in neither follower nor leader.
OM Ratis Roles on the OM endpoint sets the current node's status to follower
in that case.
> checking the condition here and not callling omHAMetricsInit() or similar.
This seems best. I'll add a check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
