xBis7 commented on code in PR #4140:
URL: https://github.com/apache/ozone/pull/4140#discussion_r1114338731
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java:
##########
@@ -1894,6 +1897,26 @@ public void updatePeerList(List<String> newPeers) {
}
}
}
+ RaftPeer leader = null;
+ try {
+ leader = omRatisServer.getLeader();
+ } catch (IOException ex) {
+ LOG.error("IOException while getting the " +
+ "Ratis server leader.", ex);
+ }
+ if (Objects.nonNull(leader)) {
+ String leaderId = leader.getId().toString();
+
+ // If leaderId is empty, then leader is undefined
+ // and current OM is neither leader nor follower.
+ // OMHAMetrics shouldn't be registered in that case.
+ if (!Strings.isNullOrEmpty(leaderId)) {
Review Comment:
@adoroszlai You are right. This was missed because the code was
```java
String leaderId = "";
try{
leader =
} catch() {
}
if (Objects.nonNull(leader)) {
}
// leaderId could be deliberately left empty down here due to failure to get
the leader
// after refactoring `String leaderId = "";` was removed.
```
> If we have any leader information, its id cannot be null.
I didn't know that.
How can we handle this now since the code has been merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
