GeorgeJahad commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1113728538
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/snapshot/OMSnapshotCreateRequest.java:
##########
@@ -150,6 +155,77 @@ public OMClientResponse
validateAndUpdateCache(OzoneManager ozoneManager,
.addCacheEntry(new CacheKey<>(key),
new CacheValue<>(Optional.of(snapshotInfo), transactionLogIndex));
+ // Create the snapshot checkpoint
+ OmSnapshotManager.createOmSnapshotCheckpoint(omMetadataManager,
+ snapshotInfo);
Review Comment:
I think OmSnapshotManager.createOmSnapshotCheckpoint() has to be called from
within OMSnapshotCreateResponse:addToDBBatch(). The special double buffer
changes @hemantk-12 made depend on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
