prashantpogde commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1119338519
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -549,6 +564,8 @@ protected void initializeOmTables(boolean addCacheMetrics)
deletedTable = this.store.getTable(DELETED_TABLE, String.class,
RepeatedOmKeyInfo.class);
checkTableStatus(deletedTable, DELETED_TABLE, addCacheMetrics);
+ // Currently, deletedTable is the only table that will need the table lock
+ tableLockMap.put(DELETED_TABLE, new ReentrantReadWriteLock(true));
Review Comment:
How will we synchronize the deletes with renames ? Wouldn't you need a table
level lock in the KeyTable and file table both ? can you also put some comments
on what the locking hiearchy is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
