smengcl commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1129816550
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmMetadataManagerImpl.java:
##########
@@ -1368,8 +1385,24 @@ public List<BlockGroup> getPendingDeletionKeys(final int
keyCount)
while (keyIter.hasNext() && currentCount < keyCount) {
KeyValue<String, RepeatedOmKeyInfo> kv = keyIter.next();
if (kv != null) {
+ // Multiple keys with the same path can be queued in one DB entry
RepeatedOmKeyInfo infoList = kv.getValue();
for (OmKeyInfo info : infoList.cloneOmKeyInfoList()) {
+ // Skip the key if it exists in the previous snapshot (of the same
+ // scope) as in this case its blocks should not be reclaimed
+
+ // TODO: HDDS-7968
+ // 1. If previous snapshot keyTable has key info.getObjectID(),
+ // skip it. Pending HDDS-7740 merge to reuse the util methods to
Review Comment:
> The check in the previous snapshot should be objectID based check
Correct. Now that #4333 is merged we are one step closer towards handling
that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
