smengcl commented on code in PR #4280:
URL: https://github.com/apache/ozone/pull/4280#discussion_r1120670348
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OmSnapshotManager.java:
##########
@@ -157,8 +162,23 @@ public static DBCheckpoint createOmSnapshotCheckpoint(
throws IOException {
RDBStore store = (RDBStore) omMetadataManager.getStore();
- final DBCheckpoint dbCheckpoint = store.getSnapshot(
- snapshotInfo.getCheckpointDirName());
+ final DBCheckpoint dbCheckpoint;
+
+ // Acquire deletedTable write lock
+ omMetadataManager.getTableLock(OmMetadataManagerImpl.DELETED_TABLE)
Review Comment:
DeleteSnapshot request only marks a snapshot as deleted but doesn't do any
cleanup. Actual clean up is done in @aswinshakil 's pending PR #4244 . And yes
that needs to hold the `deletedTable` write lock when this PR is done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
