ChenSammi commented on code in PR #4358:
URL: https://github.com/apache/ozone/pull/4358#discussion_r1138142485
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/ha/SCMHAManager.java:
##########
@@ -62,13 +63,22 @@ public interface SCMHAManager {
void stop() throws IOException;
/**
- * Adds the SC M instance to the SCM HA group.
+ * Adds the SCM instance to the SCM HA Ring.
* @param request AddSCM request
* @return status signying whether the AddSCM request succeeded or not.
* @throws IOException
*/
boolean addSCM(AddSCMRequest request) throws IOException;
+ /** Remove the SCM instance from the SCM HA Ring.
+ * @param request RemoveSCM request
+ *
+ * @return status signaling whether the RemoveSCM request succeeded or not.
+ * @throws IOException
+ */
+ boolean removeSCM(RemoveSCMRequest request) throws IOException;
+ // Change the argument to RemoveSCMRequest
Review Comment:
This comment can be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
