nandakumar131 commented on code in PR #4358:
URL: https://github.com/apache/ozone/pull/4358#discussion_r1141698588
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java:
##########
@@ -2070,4 +2071,27 @@ private String reconfOzoneAdmins(String newVal) {
newVal, admins);
return String.valueOf(newVal);
}
+
+ /**
+ * This will remove the given SCM node from HA Ring by removing it from
+ * Ratis Ring and deleting the related certificates from certificate store.
+ *
+ * @return true if remove was successful, else false.
+ */
+ public boolean removePeerFromHARing(RemoveSCMRequest request)
+ throws IOException {
+ // We cannot remove a node if it's currently leader.
+ if (scmContext.isLeader() && request.getScmId().equals(getScmId())) {
+ throw new IOException("Cannot remove current leader.");
+ }
+
+ // Currently we don't support removal of primordial node.
+ if (request.getScmId().equals(primaryScmNodeId)) {
+ throw new IOException("Removal of primordial node is not supported.");
+ }
+
+ // TODO: Remove the certificate from certificate store.
Review Comment:
There will be a new sub-task under
[HDDS-7852](https://issues.apache.org/jira/browse/HDDS-7852) for removing the
SCM certificate form the database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
