ArafatKhan2198 commented on code in PR #4406:
URL: https://github.com/apache/ozone/pull/4406#discussion_r1141465077
##########
hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/ClusterStateEndpoint.java:
##########
@@ -127,13 +131,19 @@ public Response getClusterState() {
}
Long totalKeys = 0L;
+ Long deletedKeys = 0L;
+
if (keyRecord != null) {
totalKeys += keyRecord.getValue();
}
if (fileRecord != null) {
totalKeys += fileRecord.getValue();
}
+ if (deletedKeyRecord != null) {
+ deletedKeys += deletedKeyRecord.getValue();
+ }
builder.setKeys(totalKeys);
Review Comment:
> IMO, we should just update Overview page data like number of deleted keys
in case of LEGACY/OBS buckets and number of deleted paths in case of FSO
buckets. Details of those keys can be shown and done in new requirement where I
am working currently on design for OM DB Insights and SCM DB insights page.
Thank you for sharing your suggestion. I agree with you that it would be a
good idea to differentiate the number of deleted keys in **OBS/Legacy** from
**FSO**, and we can implement a separate count in the endpoint response for
this purpose. However, for the user interface, I suggest we add both counts up
and display them as the total number of deleted keys, which will make it easier
for users to understand the overall state of the system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
