adoroszlai commented on code in PR #4389: URL: https://github.com/apache/ozone/pull/4389#discussion_r1143810047
########## hadoop-ozone/ozone-manager/pom.xml: ########## @@ -69,6 +69,12 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>ozone-interface-storage</artifactId> </dependency> + <dependency> + <groupId>org.apache.ozone</groupId> + <artifactId>ozone-s3-secret-store</artifactId> + <scope>compile</scope> + </dependency> Review Comment: > Thanks for review. I have fixed your comment. Could you please take a look again? @Pochatkin Thanks for updating the patch. It is much improved, resolving several previous comments. However, `ozone-manager` still depends on Vault, only transitively. ``` [INFO] org.apache.ozone:ozone-manager:jar:1.4.0-SNAPSHOT ... [INFO] +- org.apache.ozone:ozone-s3-secret-store:jar:1.4.0-SNAPSHOT:compile [INFO] | \- com.bettercloud:vault-java-driver:jar:5.1.0:compile ``` We need an interface. Originally I suggested this to be a separate module, but can also be in `ozone-manager` for simplicity. Vault-based implementation should depend on the module that contains the interface (separate module or `ozone-manager` depending on your choice for the above), not the other way around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
