adoroszlai commented on code in PR #4389: URL: https://github.com/apache/ozone/pull/4389#discussion_r1147605031
########## hadoop-ozone/ozone-manager/pom.xml: ########## @@ -69,6 +69,12 @@ https://maven.apache.org/xsd/maven-4.0.0.xsd";> <artifactId>ozone-interface-storage</artifactId> </dependency> + <dependency> + <groupId>org.apache.ozone</groupId> + <artifactId>ozone-s3-secret-store</artifactId> + <scope>compile</scope> + </dependency> Review Comment: Thanks @Pochatkin for updating the patch. Can you please fix checkstyle/findbugs/rat failures? https://github.com/Pochatkin/ozone/actions/runs/4499127644 Also, I think the new module should be added as a dependency to `hadoop-ozone/dist`, so that it ends up in the release tarballs. (With that I think the failed _dependency_ check will be passing again.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
