fapifta commented on PR #2466: URL: https://github.com/apache/ozone/pull/2466#issuecomment-1482778866
Looking through the patch, the change itself seems to be straigthforward, and the fact that the test are running fine after the modifications indicates for me that it will be better than it was before for sure. With that I could not get into deeper investigation on the effects of any individual change, but I have checked that the relevant piece from #2343 is included in this PR. I am +1 to commit this PR as it is, we may find more issues around the checks, but currently this seems to be better than it was. It is though important to note that it might affect those clusters that have similar access right configuration set as we had in tests, but I think this is a price we should pay, to simplify and do not make the code more complex to handle those cases. After this one, I think #2343 will become meaningless and should be closed, I will comment there why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
