fapifta commented on code in PR #4380:
URL: https://github.com/apache/ozone/pull/4380#discussion_r1134596136
##########
hadoop-hdds/framework/src/test/java/org/apache/hadoop/hdds/security/x509/certificate/client/TestDefaultCertificateClient.java:
##########
@@ -532,4 +544,53 @@ public void testRenewAndStoreKeyAndCertificate() throws
Exception {
// a success renew after auto cleanup new key and cert dir
dnCertClient.renewAndStoreKeyAndCertificate(true);
}
+
+ @Test
+ public void testCloseCertificateClient(@TempDir File metaDir)
Review Comment:
yes, done.
I also noticed two other places where we potentially do not close a client,
I have added that as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
