sumitagrawl commented on code in PR #4405:
URL: https://github.com/apache/ozone/pull/4405#discussion_r1154593059
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -720,6 +670,99 @@ public boolean delete(Path f, boolean recursive) throws
IOException {
return result;
}
+ private boolean deleteBucket(Path f, boolean recursive, OFSPath ofsPath)
+ throws IOException {
+ // check status of normal bucket
+ try {
+ getFileStatus(f);
+ } catch (FileNotFoundException ex) {
+ // remove orpahan link bucket directly
+ if (isLinkBucket(f, ofsPath)) {
+ deleteBucketFromVolume(f, ofsPath);
+ return true;
+ }
+ LOG.warn("delete: Path does not exist: {}", f);
+ return false;
+ }
+
+ // remove link bucket directly
+ if (isLinkBucket(f, ofsPath)) {
+ deleteBucketFromVolume(f, ofsPath);
+ return true;
+ }
+
+ // delete inner content of bucket
+ boolean result = innerDelete(f, recursive);
+
+ // Handle delete bucket
+ deleteBucketFromVolume(f, ofsPath);
+ return result;
+ }
+
+ private boolean isLinkBucket(Path f, OFSPath ofsPath) {
+ try {
+ OzoneBucket bucket = adapterImpl.getBucket(ofsPath, false);
+ if (bucket.isLink()) {
+ return true;
+ }
+ } catch (Exception ex) {
+ return false;
Review Comment:
@sadanand48 Updated...
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -720,6 +670,99 @@ public boolean delete(Path f, boolean recursive) throws
IOException {
return result;
}
+ private boolean deleteBucket(Path f, boolean recursive, OFSPath ofsPath)
+ throws IOException {
+ // check status of normal bucket
+ try {
+ getFileStatus(f);
+ } catch (FileNotFoundException ex) {
+ // remove orpahan link bucket directly
Review Comment:
Updated...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
