sumitagrawl commented on code in PR #4405:
URL: https://github.com/apache/ozone/pull/4405#discussion_r1155450603
##########
hadoop-ozone/ozonefs-common/src/main/java/org/apache/hadoop/fs/ozone/BasicRootedOzoneFileSystem.java:
##########
@@ -720,6 +670,101 @@ public boolean delete(Path f, boolean recursive) throws
IOException {
return result;
}
+ private boolean deleteBucket(Path f, boolean recursive, OFSPath ofsPath)
+ throws IOException {
+ // check status of normal bucket
+ try {
+ getFileStatus(f);
+ } catch (FileNotFoundException ex) {
+ // remove orphan link bucket directly
+ if (isLinkBucket(f, ofsPath)) {
Review Comment:
@neils-dev
isLinkBucket performs remote call to OM. So checking first as false in
exception, and again checking outside for link bucket bucket will have 2 remote
call. So I think this is not required to be refactored for performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
