krishnaasawa1 commented on code in PR #4556:
URL: https://github.com/apache/ozone/pull/4556#discussion_r1162641518
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMContainerPlacementRackAware.java:
##########
@@ -200,6 +200,11 @@ protected List<DatanodeDetails> chooseDatanodesInternal(
// are on different racks.
for (int i = 0; i < excludedNodesCount; i++) {
for (int j = i + 1; j < excludedNodesCount; j++) {
+ if (excludedNodes.get(j).isDecomissioned()) {
Review Comment:
excludedNodes should not have decommissioned node , isn't replicationManager
should remove decommissioned node from excludedNodes before invoking rack
awareness.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
