sodonnel commented on code in PR #4556:
URL: https://github.com/apache/ozone/pull/4556#discussion_r1162993008
##########
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/replication/LegacyReplicationManager.java:
##########
@@ -1273,6 +1273,7 @@ private List<ContainerReplica>
getReplicationSources(ContainerInfo container,
// maintenance nodes, as the replicas will remain present in the
// container manager, even when they go dead.
.filter(r -> getNodeStatus(r.getDatanodeDetails()).isHealthy()
+ && !r.getDatanodeDetails().isDecomissioned()
Review Comment:
The correct place to filter out the decommission / maintenance nodes would
be in the method "replicateAnyWithTopology", as that is where the exclude list
is formed to pass into the placement policy. But we would also need to take
care of this in the new replication manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
