kerneltime commented on code in PR #4531:
URL: https://github.com/apache/ozone/pull/4531#discussion_r1166342153
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -789,6 +789,36 @@ public OmKeyInfo copyObject() {
return builder.build();
}
+ /**
+ * Return a new copy of the object.
+ */
+ @Override
+ public Object clone() throws CloneNotSupportedException {
+ OmKeyInfo omKeyInfo = (OmKeyInfo) super.clone();
+
+ omKeyInfo.metadata = new HashMap<>();
+ omKeyInfo.keyLocationVersions = new ArrayList<>();
+ omKeyInfo.acls = new ArrayList<>();
+
+ keyLocationVersions.stream().filter(keyLocationVersion ->
+ keyLocationVersion != null).forEach(keyLocationVersion ->
+ omKeyInfo.keyLocationVersions.add(
+ new OmKeyLocationInfoGroup(keyLocationVersion.getVersion(),
+ keyLocationVersion.getLocationList(),
Review Comment:
I had the same question but looks like it is a deep copy
``` /**
* Use this expensive method only when absolutely needed!
* It creates a new list so it is not an O(1) operation.
* Use getLocationLists() instead.
* @return a list of OmKeyLocationInfo
*/
public List<OmKeyLocationInfo> getLocationList() {
return locationVersionMap.values().stream().flatMap(List::stream)
.collect(Collectors.toList());
}```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
