kerneltime commented on code in PR #4531:
URL: https://github.com/apache/ozone/pull/4531#discussion_r1167132180
##########
hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmKeyInfo.java:
##########
@@ -789,6 +789,36 @@ public OmKeyInfo copyObject() {
return builder.build();
}
+ /**
+ * Return a new copy of the object.
+ */
+ @Override
+ public Object clone() throws CloneNotSupportedException {
+ OmKeyInfo omKeyInfo = (OmKeyInfo) super.clone();
+
+ omKeyInfo.metadata = new HashMap<>();
+ omKeyInfo.keyLocationVersions = new ArrayList<>();
+ omKeyInfo.acls = new ArrayList<>();
+
+ keyLocationVersions.stream().filter(keyLocationVersion ->
+ keyLocationVersion != null).forEach(keyLocationVersion ->
+ omKeyInfo.keyLocationVersions.add(
+ new OmKeyLocationInfoGroup(keyLocationVersion.getVersion(),
+ keyLocationVersion.getLocationList(),
Review Comment:
@errose28 agreed that we need something more efficient. The entirety of
`OzoneListStatusHelper.java` and listing logic needs to be revisited. Listing
in general needs to be reviewed given that 99% of the use case does not care
about the key info, to begin with. But getting something off the cache and
returning a mutable reference is dangerous and this fix is needed to avoid
corrupting keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
