adoroszlai commented on PR #4565:
URL: https://github.com/apache/ozone/pull/4565#issuecomment-1510190986
Thanks @z-bb for updating the patch. Please take a look at CI failures:
Checkstyle:
```
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OzoneManager.java
4037: First sentence should end with a period.
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneNativeAuthorizer.java
103: Line is longer than 80 characters (found 92).
110: Line is longer than 80 characters (found 95).
202: 'ozSuperReadAdmins' hides a field.
228: Line is longer than 80 characters (found 81).
228: 'ozAdmins' hides a field.
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/security/acl/TestOzoneAdministrators.java
105: '"read operations"' has incorrect indentation level 8,
expected level should be 10.
108: '"read operations"' has incorrect indentation level 8,
expected level should be 10.
112: 'Collections' has incorrect indentation level 6, expected level should
be 8.
137: Line is longer than 80 characters (found 81).
```
https://github.com/z-bb/ozone/actions/runs/4707579758/jobs/8349518359#step:6:519
Integration test:
```
org.apache.hadoop.ozone.TestOzoneConfigurationFields.testCompareConfigurationClassAgainstXml
Time elapsed: 0.016 s <<< FAILURE!
...
2 variables missing in ozone-default.xml Entries: ozone.super.read.groups
ozone.super.read.usernames
```
(This means the new config properties introduced in `OzoneConfigKeys` also
need to be added to `hadoop-hdds/common/src/main/resources/ozone-default.xml`.)
https://github.com/z-bb/ozone/actions/runs/4707579758/jobs/8349518153#step:5:3724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
