ChenSammi commented on code in PR #4565:
URL: https://github.com/apache/ozone/pull/4565#discussion_r1168726667
##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/security/acl/OzoneNativeAuthorizer.java:
##########
@@ -101,11 +100,18 @@ public boolean checkAccess(IOzoneObj ozObject,
RequestContext context)
boolean isListAllVolume = ((context.getAclRights() == ACLType.LIST) &&
objInfo.getVolumeName().equals(OzoneConsts.OZONE_ROOT));
if (isListAllVolume) {
- return getAllowListAllVolumes();
+ return getAllowListAllVolumes()
+ || isAdmin(ozSuperReadAdmins, context.getClientUgi());
Review Comment:
Please move this isAdmin(ozSuperReadAdmins, context.getClientUgi()) to a
single assignment statement, like the above isAdmin call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
